revert!: old put contract
Some checks failed
CI / Check PR Title (pull_request) Successful in 31s
CI / Go Lint (pull_request) Failing after 43s
CI / Makefile Lint (pull_request) Successful in 49s
CI / Markdown Lint (pull_request) Successful in 34s
CI / Unit Tests (pull_request) Failing after 38s
CI / Mutation Tests (pull_request) Failing after 41s
CI / Fuzz Tests (pull_request) Failing after 41s
Some checks failed
CI / Check PR Title (pull_request) Successful in 31s
CI / Go Lint (pull_request) Failing after 43s
CI / Makefile Lint (pull_request) Successful in 49s
CI / Markdown Lint (pull_request) Successful in 34s
CI / Unit Tests (pull_request) Failing after 38s
CI / Mutation Tests (pull_request) Failing after 41s
CI / Fuzz Tests (pull_request) Failing after 41s
This commit is contained in:
14
table.go
14
table.go
@@ -153,12 +153,8 @@ func (t *Table[K, V]) Has(key K) (exists bool) {
|
||||
return
|
||||
}
|
||||
|
||||
// Put sets the value for a key. If it cannot be set, an error is returned,
|
||||
// along with the last displaced entry.
|
||||
//
|
||||
// On failure, the returned entry and the current table contents together
|
||||
// preserve all previously inserted entries and the attempted entry.
|
||||
func (t *Table[K, V]) Put(key K, value V) (displaced Entry[K, V], err error) {
|
||||
// Put sets the value for a key. If it cannot be set, an error is returned.
|
||||
func (t *Table[K, V]) Put(key K, value V) (err error) {
|
||||
var (
|
||||
entry = Entry[K, V]{key, value}
|
||||
homeless bool
|
||||
@@ -173,18 +169,18 @@ func (t *Table[K, V]) Put(key K, value V) (displaced Entry[K, V], err error) {
|
||||
// early when the table is sparse, while the latter catches cases where
|
||||
// growing never helps.
|
||||
if t.load() < t.minLoadFactor {
|
||||
return entry, fmt.Errorf("hash functions produced a cycle at load %d/%d: %w", t.Size(), t.TotalCapacity(), ErrBadHash)
|
||||
return fmt.Errorf("hash functions produced a cycle at load %d/%d: %w", t.Size(), t.TotalCapacity(), ErrBadHash)
|
||||
}
|
||||
|
||||
// It is theoretically possible to have a table with a larger capacity
|
||||
// that is valid. But this chance is astronomically small, so we ignore
|
||||
// it in this implementation.
|
||||
if grew := t.grow(); !grew {
|
||||
return entry, fmt.Errorf("could not redistribute entries into larger table: %w", ErrBadHash)
|
||||
return fmt.Errorf("could not redistribute entries into larger table: %w", ErrBadHash)
|
||||
}
|
||||
}
|
||||
|
||||
return entry, fmt.Errorf("could not place entry after %d resizes: %w", defaultGrowthLimit, ErrBadHash)
|
||||
return fmt.Errorf("could not place entry after %d resizes: %w", defaultGrowthLimit, ErrBadHash)
|
||||
}
|
||||
|
||||
// Drop removes a value for a key in the table. Returns whether the key had
|
||||
|
||||
Reference in New Issue
Block a user