feat: only one CI job at a time per PR

This prevents the Gitea runner from getting clogged up with stale CI checks.

.gitea/workflows/ci.yml

@@ -1,13 +1,16 @@
 name: CI
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 on:
   push:
     branches: [main]
   pull_request:
 
 jobs:
-  lint-go:
+  lint:
-    name: Go Lint
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -16,31 +19,11 @@ jobs:
         with:
           go-version-file: go.mod
 
-      - name: Check go mod tidy
-        run: go mod tidy && git diff --exit-code go.mod go.sum
-
       - uses: golangci/golangci-lint-action@v7
         with:
           version: latest
 
-  lint-makefile:
+  unit-test:
-    name: Makefile Lint
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: actions/setup-go@v5
-        with:
-          go-version-file: go.mod
-
-      - name: Install gremlins
-        run: go install github.com/checkmake/checkmake/cmd/checkmake@latest
-
-      - name: Run mutation tests
-        run: make lint-makefile
-
-  test-unit:
-    name: Unit Tests
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -50,10 +33,9 @@ jobs:
           go-version-file: go.mod
 
       - name: Run unit tests
-        run: make test-unit
+        run: go test ./... -cover -v
 
-  test-fuzz:
+  fuzz-test:
-    name: Fuzz Tests
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -63,10 +45,12 @@ jobs:
           go-version-file: go.mod
 
       - name: Run fuzz tests
-        run: make test-fuzz
+        run: |
+          for func in $(grep -r --include='*_test.go' -oh 'func Fuzz\w*' . | sed 's/func //'); do
+            go test ./... -fuzz="^${func}$" -fuzztime=30s
+          done
 
-  test-mutation:
+  mutation-test:
-    name: Mutation Tests
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -79,4 +63,4 @@ jobs:
         run: go install github.com/go-gremlins/gremlins/cmd/gremlins@latest
 
       - name: Run mutation tests
-        run: make test-mutation
+        run: gremlins unleash

.gremlins.yaml

@@ -5,5 +5,3 @@ unleash:
   
   workers: 4
   dry-run: false
-  threshold:
-    efficacy: 1.0

Makefile

@@ -1,44 +1,12 @@
-.PHONY: all help install clean test-unit test-mutation test-fuzz test docs lint-go lint-makefile lint
+unit:
-
-help: ## Show this help
-	@grep -E '^[a-zA-Z_-]+:.*##' $(MAKEFILE_LIST) | awk -F ':.*## ' '{printf "  %-15s %s\n", $$1, $$2}'
-
-install: ## Install dev tools
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
-	go install github.com/checkmake/checkmake/cmd/checkmake@latest
-	go install github.com/go-gremlins/gremlins/cmd/gremlins@latest
-	go install golang.org/x/tools/cmd/godoc@latest
-	go install golang.org/x/vuln/cmd/govulncheck@latest
-
-test-unit: ## Run unit tests with coverage
 	go test ./... -cover -v
 
-test-mutation: ## Run mutation tests with gremlins
+mutation:
 	gremlins unleash
 
-FUZZ_TIME ?= 30
+fuzz:
+	go test ./... -fuzz=$(FN)
 
-test-fuzz: ## Run all fuzz tests for 30s each
+docs:
-	@for func in $$(grep -r --include='*_test.go' -oh 'func Fuzz\w*' . | sed 's/func //'); do \
+	@echo ">>> Visit: http://localhost:6060/pkg/git.maximhutz.com/tools/dsa/"
-		echo "Fuzzing $$func..."; \
-		go test ./... -fuzz="^$$func$$" -fuzztime=$(FUZZ_TIME)s; \
-	done
-
-test: test-unit test-mutation test-fuzz ## Run all tests
-
-lint-go: ## Lint Go code
-	golangci-lint run ./...
-
-lint-makefile: ## Lint the Makefile
-	checkmake Makefile
-
-lint: lint-go lint-makefile ## Lint all code
-
-docs: ## Serve godoc locally
-	@echo ">>> Visit: http://localhost:6060/pkg/$$(go list -m)"
 	godoc -http=:6060
-
-clean: ## Clean build and test caches
-	go clean -cache -testcache
-
-all: lint test ## Run all checks and tests

bucket.go

@@ -17,37 +17,15 @@ type bucket[K, V any] struct {
 	compare        EqualFunc[K]
 }
 
-// location determines where in the bucket a certain key would be placed. If the
-// capacity is 0, this will panic.
 func (b bucket[K, V]) location(key K) uint64 {
 	return b.hash(key) % b.capacity
 }
 
 func (b bucket[K, V]) get(key K) (value V, found bool) {
-	if b.capacity == 0 {
-		return
-	}
-
 	slot := b.slots[b.location(key)]
 	return slot.value, slot.occupied && b.compare(slot.key, key)
 }
 
-func (b *bucket[K, V]) drop(key K) (occupied bool) {
-	if b.capacity == 0 {
-		return
-	}
-
-	slot := &b.slots[b.location(key)]
-
-	if slot.occupied && b.compare(slot.key, key) {
-		slot.occupied = false
-		b.size--
-		return true
-	}
-
-	return false
-}
-
 func (b *bucket[K, V]) resize(capacity uint64) {
 	b.slots = make([]slot[K, V], capacity)
 	b.capacity = capacity
@@ -55,10 +33,6 @@ func (b *bucket[K, V]) resize(capacity uint64) {
 }
 
 func (b bucket[K, V]) update(key K, value V) (updated bool) {
-	if b.capacity == 0 {
-		return
-	}
-
 	slot := &b.slots[b.location(key)]
 
 	if slot.occupied && b.compare(slot.key, key) {
@@ -70,10 +44,6 @@ func (b bucket[K, V]) update(key K, value V) (updated bool) {
 }
 
 func (b *bucket[K, V]) evict(insertion entry[K, V]) (evicted entry[K, V], eviction bool) {
-	if b.capacity == 0 {
-		return insertion, true
-	}
-
 	slot := &b.slots[b.location(insertion.key)]
 
 	if !slot.occupied {

cuckoo_fuzz_test.go

@@ -1,11 +1,11 @@
 package cuckoo_test
 
 import (
-	"maps"
+	"bytes"
+	"encoding/binary"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	go_fuzz_utils "github.com/trailofbits/go-fuzz-utils"
 
 	"git.maximhutz.com/tools/go-cuckoo"
 )
@@ -19,60 +19,31 @@ func offsetHash(seed uint32) cuckoo.Hash[uint32] {
 	}
 }
 
-type fuzzStep struct {
-	drop       bool
-	key, value uint32
-}
-
-type fuzzScenario struct {
-	seedA, seedB uint32
-	steps        []fuzzStep
-}
-
 func FuzzInsertLookup(f *testing.F) {
-	f.Fuzz(func(t *testing.T, data []byte) {
+	f.Fuzz(func(t *testing.T, data []byte, seedA, seedB uint32) {
-		var scenario fuzzScenario
 		assert := assert.New(t)
 
-		if tp, err := go_fuzz_utils.NewTypeProvider(data); err != nil {
+		table := cuckoo.NewCustomTable[uint32, uint32](
-			return
+			offsetHash(seedA),
-		} else if err := tp.Fill(&scenario); err != nil {
+			offsetHash(seedB),
-			return
-		}
-
-		if scenario.seedA == scenario.seedB {
-			return
-		}
-
-		actual := cuckoo.NewCustomTable[uint32, uint32](
-			offsetHash(scenario.seedA),
-			offsetHash(scenario.seedB),
 			func(a, b uint32) bool { return a == b },
 		)
 
-		expected := map[uint32]uint32{}
+		if seedA == seedB {
+			return
+		}
 
-		for _, step := range scenario.steps {
+		r := bytes.NewReader(data)
-			if step.drop {
+		var key, value uint32
-				err := actual.Drop(step.key)
+		for binary.Read(r, binary.LittleEndian, &key) == nil &&
-				assert.NoError(err)
+			binary.Read(r, binary.LittleEndian, &value) == nil {
 
-				delete(expected, step.key)
+			err := table.Put(key, value)
+			assert.NoError(err)
 
-				_, err = actual.Get(step.key)
+			found, err := table.Get(key)
-				assert.Error(err)
+			assert.NoError(err)
-			} else {
+			assert.Equal(value, found)
-				err := actual.Put(step.key, step.value)
-				assert.NoError(err)
-
-				expected[step.key] = step.value
-
-				found, err := actual.Get(step.key)
-				assert.NoError(err)
-				assert.Equal(step.value, found)
-			}
-
-			assert.Equal(expected, maps.Collect(actual.Entries()))
 		}
 	})
 }

cuckoo_internal_test.go

@@ -25,6 +25,6 @@ func TestLoad(t *testing.T) {
 	for i := range 16 {
 		err := table.Put(i, true)
 		assert.NoError(err)
-		assert.Equal(float64(table.Size())/float64(table.TotalCapacity()), table.load())
+		assert.Equal(float64(table.Size())/float64(table.Capacity()), table.load())
 	}
 }

cuckoo_test.go

@@ -1,7 +1,6 @@
 package cuckoo_test
 
 import (
-	"errors"
 	"maps"
 	"math/rand/v2"
 	"testing"
@@ -65,7 +64,7 @@ func TestStartingCapacity(t *testing.T) {
 	assert := assert.New(t)
 	table := cuckoo.NewTable[int, bool](cuckoo.Capacity(64))
 
-	assert.Equal(uint64(128), table.TotalCapacity())
+	assert.Equal(uint64(128), table.Capacity())
 }
 
 func TestResizeCapacity(t *testing.T) {
@@ -75,12 +74,12 @@ func TestResizeCapacity(t *testing.T) {
 		cuckoo.GrowthFactor(2),
 	)
 
-	for table.TotalCapacity() == 16 {
+	for table.Capacity() == 16 {
 		err := table.Put(rand.Int(), true)
 		assert.NoError(err)
 	}
 
-	assert.Equal(uint64(32), table.TotalCapacity())
+	assert.Equal(uint64(32), table.Capacity())
 }
 
 func TestPutMany(t *testing.T) {
@@ -129,113 +128,3 @@ func TestRemove(t *testing.T) {
 
 	assert.True(table.Has(0))
 }
-
-func TestDropExistingItem(t *testing.T) {
-	assert := assert.New(t)
-	key, value := 0, true
-	table := cuckoo.NewTable[int, bool]()
-	(table.Put(key, value))
-
-	err := table.Drop(key)
-
-	assert.NoError(err)
-	assert.Equal(0, table.Size())
-	assert.False(table.Has(key))
-}
-
-func TestDropNoItem(t *testing.T) {
-	assert := assert.New(t)
-	key := 0
-	table := cuckoo.NewTable[int, bool]()
-
-	err := table.Drop(key)
-
-	assert.NoError(err)
-	assert.Equal(0, table.Size())
-	assert.False(table.Has(key))
-}
-
-func TestDropItemCapacity(t *testing.T) {
-	assert := assert.New(t)
-	key := 0
-	table := cuckoo.NewTable[int, bool](
-		cuckoo.Capacity(64),
-		cuckoo.GrowthFactor(2),
-	)
-
-	startingCapacity := table.TotalCapacity()
-	err := table.Drop(key)
-	endingCapacity := table.TotalCapacity()
-
-	assert.NoError(err)
-	assert.Equal(0, table.Size())
-	assert.Equal(uint64(128), startingCapacity)
-	assert.Equal(uint64(64), endingCapacity)
-}
-
-func TestPutNoCapacity(t *testing.T) {
-	assert := assert.New(t)
-	key, value := 0, true
-	table := cuckoo.NewTable[int, bool](
-		cuckoo.Capacity(0),
-	)
-
-	err := table.Put(key, value)
-
-	assert.NoError(err)
-	assert.Equal(1, table.Size())
-	assert.True(table.Has(key))
-}
-
-func TestBadHashCapacity(t *testing.T) {
-	assert := assert.New(t)
-	table := cuckoo.NewCustomTable[int, bool](
-		func(int) uint64 { return 0 },
-		func(int) uint64 { return 0 },
-		func(a, b int) bool { return a == b },
-		cuckoo.Capacity(20),
-	)
-
-	err1 := table.Put(0, true)
-	err2 := table.Put(1, true)
-	err3 := table.Put(2, true)
-
-	assert.NoError(err1)
-	assert.NoError(err2)
-	assert.Error(err3)
-
-	assert.Equal(uint64(80), table.TotalCapacity())
-}
-
-func TestDropResizeCapacity(t *testing.T) {
-	assert := assert.New(t)
-	table := cuckoo.NewTable[int, bool](
-		cuckoo.Capacity(10),
-	)
-
-	err1 := table.Put(0, true)
-	err2 := table.Put(1, true)
-	err3 := table.Drop(1)
-
-	assert.NoError(errors.Join(err1, err2, err3))
-	assert.Equal(uint64(20), table.TotalCapacity())
-}
-
-func TestNewTableBy(t *testing.T) {
-	type User struct {
-		_    func()
-		id   string
-		name string
-	}
-
-	assert := assert.New(t)
-	table := cuckoo.NewTableBy[User, bool](
-		func(u User) string { return u.id },
-	)
-
-	err := table.Put(User{nil, "1", "Robert"}, true)
-
-	assert.NoError(err)
-	assert.Equal(1, table.Size())
-	assert.True(table.Has(User{nil, "1", "Robbie"}))
-}

go.mod

@@ -4,11 +4,8 @@ go 1.25.6
 
 require github.com/stretchr/testify v1.11.1
 
-require github.com/kr/pretty v0.3.1 // indirect
-
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	github.com/trailofbits/go-fuzz-utils v0.0.0-20260318143407-0907cafe7589
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.sum

@@ -1,21 +1,9 @@
-github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
-github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
-github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
-github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
-github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
-github.com/rogpeppe/go-internal v1.9.0 h1:73kH8U+JUqXU8lRuOHeVHaa/SZPifC7BkcraZVejAe8=
-github.com/rogpeppe/go-internal v1.9.0/go.mod h1:WtVeX8xhTBvf0smdhujwtBcq4Qrzq/fJaraNFVN+nFs=
 github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
 github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
-github.com/trailofbits/go-fuzz-utils v0.0.0-20260318143407-0907cafe7589 h1:UmBZCTPdDYore2IEHN+U4eIqEaRq6METh9pKiPumkqc=
-github.com/trailofbits/go-fuzz-utils v0.0.0-20260318143407-0907cafe7589/go.mod h1:zh+T+w9XT/3o4E0WLEGCdmLJ8Yqx/zY3o538tQY3OjY=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
-gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
-gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

table.go

@@ -16,9 +16,9 @@ type Table[K, V any] struct {
 	minLoadFactor    float64
 }
 
-// TotalCapacity returns the number of slots allocated for the [Table]. To get the
+// Capacity returns the number of slots allocated for the [Table]. To get the
 // number of slots filled, look at [Table.Size].
-func (t Table[K, V]) TotalCapacity() uint64 {
+func (t Table[K, V]) Capacity() uint64 {
 	return t.bucketA.capacity + t.bucketB.capacity
 }
 
@@ -28,34 +28,25 @@ func (t Table[K, V]) Size() int {
 }
 
 func log2(n uint64) (m int) {
-	return max(0, bits.Len64(n)-1)
+	return bits.Len64(n) - 1
 }
 
 func (t Table[K, V]) maxEvictions() int {
-	return 3 * log2(t.TotalCapacity())
+	return 3 * log2(t.Capacity())
 }
 
 func (t Table[K, V]) load() float64 {
-	// When there are no slots in the table, we still treat the load as 100%.
+	return float64(t.Size()) / float64(t.Capacity())
-	// Every slot in the table is full.
-	if t.TotalCapacity() == 0 {
-		return 1.0
-	}
-
-	return float64(t.Size()) / float64(t.TotalCapacity())
 }
 
-// resize clears all buckets, changes the sizes of them to a specific capacity,
+func (t *Table[K, V]) resize() error {
-// and fills them back up again. It is a helper function for [Table.grow] and
-// [Table.shrink]; use them instead.
-func (t *Table[K, V]) resize(capacity uint64) error {
 	entries := make([]entry[K, V], 0, t.Size())
 	for k, v := range t.Entries() {
 		entries = append(entries, entry[K, V]{k, v})
 	}
 
-	t.bucketA.resize(capacity)
+	t.bucketA.resize(t.growthFactor * t.bucketA.capacity)
-	t.bucketB.resize(capacity)
+	t.bucketB.resize(t.growthFactor * t.bucketB.capacity)
 
 	for _, entry := range entries {
 		if err := t.Put(entry.key, entry.value); err != nil {
@@ -66,26 +57,6 @@ func (t *Table[K, V]) resize(capacity uint64) error {
 	return nil
 }
 
-// grow increases the table's capacity by the [Table.growthFactor]. If the
-// capacity is 0, it increases it to 1.
-func (t *Table[K, V]) grow() error {
-	var newCapacity uint64
-
-	if t.TotalCapacity() == 0 {
-		newCapacity = 1
-	} else {
-		newCapacity = t.bucketA.capacity * t.growthFactor
-	}
-
-	return t.resize(newCapacity)
-}
-
-// shrink reduces the table's capacity by the [Table.growthFactor]. It may
-// reduce it down to 0.
-func (t *Table[K, V]) shrink() error {
-	return t.resize(t.bucketA.capacity / t.growthFactor)
-}
-
 // Get fetches the value for a key in the [Table]. Returns an error if no value
 // is found.
 func (t Table[K, V]) Get(key K) (value V, err error) {
@@ -128,10 +99,10 @@ func (t *Table[K, V]) Put(key K, value V) (err error) {
 	}
 
 	if t.load() < t.minLoadFactor {
-		return fmt.Errorf("bad hash: resize on load %d/%d = %f", t.Size(), t.TotalCapacity(), t.load())
+		return fmt.Errorf("bad hash: resize on load %d/%d = %f", t.Size(), t.Capacity(), t.load())
 	}
 
-	if err := t.grow(); err != nil {
+	if err := t.resize(); err != nil {
 		return err
 	}
 
@@ -140,15 +111,10 @@ func (t *Table[K, V]) Put(key K, value V) (err error) {
 
 // Drop removes a value for a key in the table. Returns an error if its value
 // cannot be removed.
-func (t *Table[K, V]) Drop(key K) (err error) {
+//
-	t.bucketA.drop(key)
+// Deprecated: Do not use.
-	t.bucketB.drop(key)
+func (t Table[K, V]) Drop(_ K) {
-
+	panic("Not implemented")
-	if t.load() < t.minLoadFactor {
-		return t.shrink()
-	}
-
-	return nil
 }
 
 // Entries returns an unordered sequence of all key-value pairs in the table.