fix: reduce minimum load in tests to <20%

- This always causes errors, it should not be possible.

.claude/settings.json

@@ -0,0 +1,7 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(curl -s -w \"\\\\n---HTTP_STATUS:%{http_code}---\" https://raw.githubusercontent.com/kubernetes/kubernetes/master/.markdownlint.yaml)"
+    ]
+  }
+}

.gitea/ISSUE_TEMPLATE/BUG_REPORT.yml

@@ -1,26 +0,0 @@
-# yaml-language-server: $schema=https://www.schemastore.org/gitea-issue-forms.json
-name: 🐛 Bug Report
-about: Report a bug in this project
-title: "[BUG]: "
-body:
-  - type: textarea
-    id: context
-    attributes:
-      label: Context
-      placeholder: What circumstances led to the bug?
-    validations:
-      required: true
-  - type: textarea
-    id: expected-behavior
-    attributes:
-      label: Expected Behavior
-      placeholder: What did you expect would happen?
-    validations:
-      required: true
-  - type: textarea
-    id: actual-behavior
-    attributes:
-      label: Actual Behavior
-      placeholder: What happened, and why was it unexpected?
-    validations:
-      required: true

.gitea/ISSUE_TEMPLATE/FEATURE_REQUEST.yml

@@ -1,37 +0,0 @@
-# 'Feature Request Template' By @cheehwatang
-# https://github.com/cheehwatang/.github/blob/master/.github/ISSUE_TEMPLATE/feature_request.yml
-#
-# yaml-language-server: $schema=https://www.schemastore.org/gitea-issue-forms.json
-name: ✨ Feature Request
-about: Suggest an idea for this project
-title: "[FEATURE]: "
-body:
-  - type: dropdown
-    attributes:
-      multiple: false
-      label: Feature Type
-      options:
-        - "✨ New Feature"
-        - "📝 Documentation"
-        - "🎨 Style and UI"
-        - "🔨 Code Refactor"
-        - "⚡ Performance Improvements"
-        - "✅ New Test"
-    validations:
-      required: true
-  - type: textarea
-    id: description
-    attributes:
-      label: Description
-      placeholder: |
-        Give us a brief description of the feature or enhancement you would
-        like!
-    validations:
-      required: true
-  - type: textarea
-    id: additional-information
-    attributes:
-      label: Additional Information
-      placeholder: |
-        Give us some additional information on the feature request like proposed
-        solutions, links, screenshots, etc.

.gitea/ISSUE_TEMPLATE/config.yml

@@ -1,2 +0,0 @@
-# yaml-language-server: $schema=https://www.schemastore.org/gitea-issue-config.json
-blank_issues_enabled: false

.gitea/PULL_REQUEST_TEMPLATE.md

@@ -1,17 +0,0 @@
----
-name: "New Pull Request"
-about: "Standard PR template"
-title: ""
-ref: "main"
----
-
-## Description
-
-## Changes
-
-### Design Decisions
-
-## Checklist
-
-- [ ] Tests pass
-- [ ] Docs updated

.gitea/workflows/ci.yml

@@ -6,19 +6,6 @@ on:
   pull_request:
 
 jobs:
-  check-pr-title:
-    name: Check PR Title
-    runs-on: ubuntu-latest
-    if: github.event_name == 'pull_request'
-    env:
-      TITLE: ${{ gitea.event.pull_request.title }}
-    steps:
-      - run: |
-          if ! echo "$TITLE" | grep -qE '^(WIP: )?(feat|fix|docs|chore|ci|test|refactor|perf|build|style|revert)(\(.+\))?(!)?: .+'; then
-            echo "::error::Pull Request title must follow conventional commits"
-            exit 1
-          fi
-
   lint-go:
     name: Go Lint
     runs-on: ubuntu-latest

.gitignore

@@ -24,3 +24,4 @@ go.work.sum
 
 # env file
 .env
+

cuckoo_fuzz_test.go

@@ -3,6 +3,7 @@ package cuckoo_test
 import (
 	"fmt"
 	"maps"
+	"math"
 	"os"
 	"testing"
 
@@ -29,6 +30,7 @@ type fuzzStep struct {
 type fuzzScenario struct {
 	seedA, seedB           uint32
 	capacity, growthFactor uint8
+	load                   float64
 	steps                  []fuzzStep
 }
 
@@ -46,6 +48,7 @@ func FuzzInsertLookup(f *testing.F) {
 		seedA, seedB := scenario.seedA, scenario.seedB
 		growthFactor := max(2, int(scenario.growthFactor))
 		capacity := int(scenario.capacity)
+		minimumLoad := math.Abs(math.Mod(scenario.load, 1.0))
 
 		// If they are the same number, the hashes will clash, always causing an
 		// error.
@@ -53,8 +56,14 @@ func FuzzInsertLookup(f *testing.F) {
 			t.Skip()
 		}
 
-		fmt.Fprintf(os.Stderr, "seedA=%d seedB=%d capacity=%d growthFactor=%d\n",
-			seedA, seedB, capacity, growthFactor)
+		// If the load is too high, the hashs will not be able to allocate
+		// properly.
+		if minimumLoad > 0.20 {
+			t.Skip()
+		}
+
+		fmt.Fprintf(os.Stderr, "seedA=%d seedB=%d capacity=%d growthFactor=%d minimumLoad=%f\n",
+			seedA, seedB, capacity, growthFactor, minimumLoad)
 
 		actual := cuckoo.NewCustomTable[uint32, uint32](
 			offsetHash(seedA),
@@ -62,6 +71,7 @@ func FuzzInsertLookup(f *testing.F) {
 			func(a, b uint32) bool { return a == b },
 			cuckoo.Capacity(capacity),
 			cuckoo.GrowthFactor(growthFactor),
+			cuckoo.MinimumLoad(minimumLoad),
 		)
 
 		expected := map[uint32]uint32{}

cuckoo_test.go

@@ -118,6 +118,18 @@ func TestGetMany(t *testing.T) {
 	}
 }
 
+func TestRemove(t *testing.T) {
+	assert := assert.New(t)
+	table := cuckoo.NewTable[int, bool]()
+
+	assert.False(table.Has(0))
+
+	err := table.Put(0, true)
+	assert.NoError(err)
+
+	assert.True(table.Has(0))
+}
+
 func TestDropExistingItem(t *testing.T) {
 	assert := assert.New(t)
 	key, value := 0, true

settings.go

@@ -12,12 +12,11 @@ const DefaultCapacity uint64 = 16
 // hash table implementations use 2.
 const DefaultGrowthFactor uint64 = 2
 
-// defaultMinimumLoad is the default lowest acceptable occupancy of a [Table].
-// The higher the minimum load, the more likely that a [Table.Put] will not
-// succeed. The value of 5% is taken from [libcuckoo].
+// DefaultMinimumLoad is the default lowest acceptable occupancy of a [Table].
+// The value of 5% is taken from [libcuckoo].
 //
 // [libcuckoo]: https://github.com/efficient/libcuckoo/blob/656714705a055df2b7a605eb3c71586d9da1e119/libcuckoo/cuckoohash_config.hh#L21
-const defaultMinimumLoad float64 = 0.05
+const DefaultMinimumLoad float64 = 0.05
 
 type settings struct {
 	growthFactor  uint64
@@ -39,6 +38,16 @@ func Capacity(value int) Option {
 	return func(s *settings) { s.bucketSize = uint64(value) }
 }
 
+// MinimumLoad modifies the [DefaultMinimumLoad] of the [Table]. The value must
+// be between 0.00 and 1.00.
+func MinimumLoad(value float64) Option {
+	if value < 0.00 || value > 1.00 {
+		panic(fmt.Sprintf("go-cuckoo: MinimumLoad must be between 0.00 and 1.00, got %f", value))
+	}
+
+	return func(s *settings) { s.minLoadFactor = value }
+}
+
 // GrowthFactor controls how much the capacity of the [Table] multiplies when
 // it must resize. The value must be greater than 1.
 func GrowthFactor(value int) Option {

table.go

@@ -198,7 +198,7 @@ func NewCustomTable[K, V any](hashA, hashB Hash[K], compare EqualFunc[K], option
 	settings := &settings{
 		growthFactor:  DefaultGrowthFactor,
 		bucketSize:    DefaultCapacity,
-		minLoadFactor: defaultMinimumLoad,
+		minLoadFactor: DefaultMinimumLoad,
 	}
 
 	for _, option := range options {