tools/go-cuckoo
1
0
Fork 0
Code Issues 2 Pull Requests Actions Releases 4 Wiki Activity

feat: sentinel error ErrBadHash #19

Merged
mvhutz merged 2 commits from feat/sentinel-errors into main 2026-04-14 00:38:11 +00:00
Conversation 0 Commits 2 Files Changed 1 +10 -1
mvhutz commented 2026-04-03 19:09:48 +00:00
Owner
Copy Link

Description

Currently, the errors are not sentinel, and so are hard to test for. This PR makes sure hash collision errors are accounted for.

Changes

  • Add ErrBadHash. Happens when there are too many collisions for an item to be added.

Design Decisions

  • Chose to name ErrBadHash over ErrCycle because the feedbach that the user should be given is to evaluate their hash functions. Cycle collision is a bit esoteric.

Checklist

  • Tests pass
  • Docs updated
## Description Currently, the errors are not sentinel, and so are hard to test for. This PR makes sure hash collision errors are accounted for. ## Changes - Add `ErrBadHash`. Happens when there are too many collisions for an item to be added. ### Design Decisions - Chose to name `ErrBadHash` over `ErrCycle` because the feedbach that the user should be given is to evaluate their hash functions. Cycle collision is a bit esoteric. ## Checklist - [x] Tests pass - [x] Docs updated
mvhutz added 1 commit 2026-04-03 19:09:49 +00:00
feat: sentinel error for collision cycle
All checks were successful
CI / Check PR Title (pull_request) Successful in 19s
Details
CI / Go Lint (pull_request) Successful in 41s
Details
CI / Makefile Lint (pull_request) Successful in 38s
Details
CI / Markdown Lint (pull_request) Successful in 22s
Details
CI / Unit Tests (pull_request) Successful in 47s
Details
CI / Fuzz Tests (pull_request) Successful in 1m10s
Details
CI / Mutation Tests (pull_request) Successful in 1m17s
Details
7bcb68b3b1
mvhutz added 1 commit 2026-04-03 19:16:26 +00:00
docs: recommend rebuilding the table
All checks were successful
CI / Check PR Title (pull_request) Successful in 19s
Details
CI / Go Lint (pull_request) Successful in 41s
Details
CI / Makefile Lint (pull_request) Successful in 39s
Details
CI / Markdown Lint (pull_request) Successful in 22s
Details
CI / Unit Tests (pull_request) Successful in 38s
Details
CI / Fuzz Tests (pull_request) Successful in 1m10s
Details
CI / Mutation Tests (pull_request) Successful in 1m8s
Details
f4c0f349ba
mvhutz merged commit 867a1d49df into main 2026-04-14 00:38:11 +00:00
mvhutz deleted branch feat/sentinel-errors 2026-04-14 00:38:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
mvhutz
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tools/go-cuckoo#19
Delete Branch "feat/sentinel-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?