feat: add drop key functionality #6

Merged

mvhutz merged 12 commits from feat/drop-item into main 2026-03-20 01:59:55 +00:00

Conversation 0 Commits 12 Files Changed 9

+262 -40

mvhutz commented 2026-03-20 00:57:01 +00:00

Owner

Copy Link

Copy Source

Currently, the Table.Drop() function is deprecated because it is not implemented yet. Let's add that functionality.

• Adds true drop functionality to the table, through Table.Drop().
• Adds tests for functionality.
• Rewrites fuzz test using go_fuzz_utils, to test arbitrary usage patterns.
• Rewrite bucket to allow a capacity of zero.
• Rename Table.Capacity() to Table.TotalCapacity(), to reflect to different between the capacity of the buckets vs. the whole table.
• Enforce 100% mutation test coverage.

Currently, the `Table.Drop()` function is deprecated because it is not implemented yet. Let's add that functionality. - Adds true drop functionality to the table, through `Table.Drop()`. - Adds tests for functionality. - Rewrites fuzz test using `go_fuzz_utils`, to test arbitrary usage patterns. - Rewrite `bucket` to allow a capacity of zero. - Rename `Table.Capacity()` to `Table.TotalCapacity()`, to reflect to different between the capacity of the buckets vs. the whole table. - Enforce 100% mutation test coverage.

mvhutz added 7 commits 2026-03-20 00:57:02 +00:00

feat: implement drop functionality ... d4acdda95b

- Added `drop()` function in buckets.
- Implemented `Drop()` function for Table.

fix: drop() decrements bucket size 74ed81761c

fix: resize of Table.Drop() now decreases size ... c1314f8a3c

- Generalized Table.resize() to accept a capacity size for each bucket.

fix: Table.Drop() was not a pointer receiver e2ba398a62

test: add Drop to fuzz test, add drop test cases bb874a2aba

fix: allow 0 capacity for table ... cdb5efb4a3

- Added guards at the bucket level, to ensure that getting an item in an empty bucket doesn't cause an error.
- Added grow() and shrink() functions to Table, to prevent a capacity of 0 from not being able to grow.
- Updated the fuzz test to use `go_fuzz-utils`.

chore: removed testdata for fuzz test bd3f0aad04

mvhutz added 1 commit 2026-03-20 01:06:37 +00:00

docs: added comments to give context to functions 0c81bc5cae

mvhutz added 1 commit 2026-03-20 01:08:40 +00:00

chore: go mod tidy f636ce8911

mvhutz marked the pull request as ready for review 2026-03-20 01:08:54 +00:00

mvhutz added 1 commit 2026-03-20 01:20:53 +00:00

ci: enforce 100% mutation coverage ... afd3472d1d

This will strongly indicate whether the test cases actually cover.

mvhutz added 1 commit 2026-03-20 01:23:41 +00:00

fix: mutation test threshold should be in config ... cd115ba7a2

There isn't a `--threshold` flag for `go-gremlins`.

mvhutz added 1 commit 2026-03-20 01:57:55 +00:00

feat: 100% mutation test coverage ... 09b5d9d893

- Fixed mutation coverage to be 1.0, instead of 100.

mvhutz merged commit 56b1982f8a into main 2026-03-20 01:59:55 +00:00

mvhutz deleted branch feat/drop-item 2026-03-20 01:59:55 +00:00

mvhutz referenced this issue from a commit 2026-03-20 01:59:55 +00:00

feat: add drop key functionality (#6)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

mvhutz (Maxim Hutz)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: tools/go-cuckoo#6