mvhutz/lambda
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Makefile improvements and cleanup #2

Closed
mvhutz wants to merge 16 commits from chore/makefile-improvements into main
pull from: chore/makefile-improvements
merge into: mvhutz:main
Conversation 0 Commits 16 Files Changed 8 +41 -193
mvhutz commented 2026-01-10 22:16:30 +00:00
Owner
Copy Link

Improvements to the Makefile:

  • Use .SILENT directive instead of @ prefixes
  • Add explicit .PHONY declarations
  • Set help as default target
  • Fix profile target dependencies
  • Add lambda binary to .gitignore
  • Remove old makefile-improvements.md documentation
Improvements to the Makefile: - Use .SILENT directive instead of @ prefixes - Add explicit .PHONY declarations - Set help as default target - Fix profile target dependencies - Add lambda binary to .gitignore - Remove old makefile-improvements.md documentation
mvhutz added 16 commits 2026-01-10 22:16:30 +00:00
style: remove decorative comment separators b2b2655c1e
style: remove comments from golangci config 9f06a5109f
style: remove YAML document separator 7e59d5cefa
feat: add usage instructions to README and improve Makefile dc9a1b2b7d
fix: remove Windows .exe extension from binary name 0d06fac919 
Changed BINARY_NAME from lambda.exe to lambda for Unix systems.
The .exe extension is a Windows convention and is inappropriate
for macOS/Linux builds.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
refactor: remove redundant chmod +x command e0b0b92a8a 
Go build already sets the executable bit on binaries, making the
explicit chmod +x unnecessary.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
feat: add .PHONY declarations for all targets e5ceeb2fcc 
Declares all non-file targets as phony to prevent conflicts with
files of the same name and improve Make's performance.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
feat: add clean target to remove build artifacts 7927df4660 
Adds standard clean target to remove binary, output files, and
profile directory.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
feat: add help target to document available commands 24fdc1c17c 
Adds help target that displays all available Make targets and their
descriptions, improving discoverability.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
fix: ensure profile directory exists before writing bb48d0777b 
Creates profile directory in profile and explain targets to prevent
errors on first run.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
fix: add profile dependency to graph target 3158c35df2 
Makes graph target depend on profile to ensure cpu.prof exists
before attempting to generate visualizations.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
refactor: use .SILENT directive instead of @ prefixes 8f70bfbbdb 
Adds .SILENT directive to suppress command echoing for all targets,
replacing individual @ prefixes. Also moves TEST variable to top with
other variables for better organization.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
docs: add documentation of Makefile improvements 997794eaa5 
Documents all issues found and fixes applied to the Makefile,
including both implemented changes and remaining suggestions.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
fix: add lambda binary to .gitignore b3db983f62 
Adds the lambda binary to .gitignore to prevent accidentally
committing the build artifact. Previously only *.exe was ignored,
which didn't cover the Unix binary name.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
feat: explicitly set help as default target edfee89bad 
Adds .DEFAULT_GOAL := help to make it clear that running 'make'
with no arguments will display the help message.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
docs: remove makefile-improvements.md in favor of CLAUDE.md 602d8fa074 
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
mvhutz force-pushed chore/makefile-improvements from 602d8fa074 to b6133aa76e 2026-01-10 22:19:50 +00:00 Compare
mvhutz closed this pull request 2026-01-10 22:21:39 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
mvhutz
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mvhutz/lambda#2
Delete Branch "chore/makefile-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?