refactor: simplify iterator.Try and remove unnecessary backtracking #47

mvhutz · 2026-02-12T01:04:16Z

mvhutz commented

2026-02-12 01:04:16 +00:00

Description

iterator.Try previously copied the entire iterator and synced it back on success, causing an unnecessary heap allocation on every call.
This PR simplifies Try to save and restore the index directly, and removes the now-unused Copy and Sync methods.

Rewrite ScanRune and ParseRawToken as peek-then-advance, eliminating the need for Try at leaf level.
Remove redundant Try wrappers from parseExpression, parseAbstraction, parseApplication, parseLet, and parseToken, which are already disambiguated by their callers.
Keep Try only where true backtracking is needed: parseStatement, which must choose between parseLet and parseDeclare.
Fix pre-existing panic in saccharine parseExpression when the iterator is exhausted (added Done() guard).

Decisions

Try now operates on the original iterator instead of a copy, removing the confusing pattern where the callback's i was a different object than the caller's i.
Removed parseSoftBreak and parseHardBreak helper functions since ParseRawToken no longer needs Try wrapping.

Benefits

Eliminates a heap allocation per Try call.
Reduces nesting and indirection in all parse functions.
Makes the code easier to follow by removing the shadow-i pattern.
Try is now only used at genuine choice points in the grammar.

Checklist

Code follows conventional commit format.
Branch follows naming convention (<type>/<description>). Always use underscores.
Tests pass (if applicable).
Documentation updated (if applicable).

## Description `iterator.Try` previously copied the entire iterator and synced it back on success, causing an unnecessary heap allocation on every call. This PR simplifies `Try` to save and restore the index directly, and removes the now-unused `Copy` and `Sync` methods. - Rewrite `ScanRune` and `ParseRawToken` as peek-then-advance, eliminating the need for `Try` at leaf level. - Remove redundant `Try` wrappers from `parseExpression`, `parseAbstraction`, `parseApplication`, `parseLet`, and `parseToken`, which are already disambiguated by their callers. - Keep `Try` only where true backtracking is needed: `parseStatement`, which must choose between `parseLet` and `parseDeclare`. - Fix pre-existing panic in saccharine `parseExpression` when the iterator is exhausted (added `Done()` guard). ### Decisions - `Try` now operates on the original iterator instead of a copy, removing the confusing pattern where the callback's `i` was a different object than the caller's `i`. - Removed `parseSoftBreak` and `parseHardBreak` helper functions since `ParseRawToken` no longer needs `Try` wrapping. ## Benefits - Eliminates a heap allocation per `Try` call. - Reduces nesting and indirection in all parse functions. - Makes the code easier to follow by removing the shadow-`i` pattern. - `Try` is now only used at genuine choice points in the grammar. ## Checklist - [x] Code follows conventional commit format. - [x] Branch follows naming convention (`<type>/<description>`). Always use underscores. - [x] Tests pass (if applicable). - [x] Documentation updated (if applicable).

mvhutz added 1 commit 2026-02-12 01:04:17 +00:00

refactor: simplify iterator.Try and remove unnecessary backtracking b1fef85d60

Simplify Try to save/restore the index directly instead of
copying and syncing the entire iterator. Remove the now-unused
Copy and Sync methods.

Rewrite ScanRune and ParseRawToken as peek-then-advance so they
no longer need Try at all. Remove redundant Try wrappers from
parse functions that are already disambiguated by their callers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mvhutz merged commit aca197ef51 into main

2026-02-12 01:04:27 +00:00

mvhutz deleted branch refactor/simplify-iterator-try

2026-02-12 01:04:27 +00:00

mvhutz referenced this issue from a commit

2026-02-12 01:04:27 +00:00

refactor: simplify iterator.Try and remove unnecessary backtracking (#47)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mvhutz/lambda#47