## Description The `internal/cli` package had grown to contain both CLI utilities (source/destination I/O) and registry-level abstractions (repr, conversion, engine, marshaler). This PR separates concerns by moving registry types into `internal/registry` and keeping only CLI I/O types in `internal/cli`. It also simplifies several core abstractions and aligns naming conventions. - Move `Source`, `Destination` from `internal/config` to `internal/cli`. - Move `Repr`, `Conversion`, `Engine`, `Process`, `Codec` from `internal/cli` to `internal/registry`. - Rename "marshalers" to "codecs" throughout the codebase. - Simplify `codec.Codec[T, U]` to `codec.Codec[T]` (string-based marshaling only). - Add `codec.Conversion[T, U]` as a function type alias. - Change `engine.Engine[T]` from an interface to a function type. - Merge `Engine.Load()` + `Process.Set()` into a single `Engine.Load(Repr)` call. - Convert `Saccharine2Lambda` from a struct to standalone conversion functions. - Replace registry methods (`MustAddMarshaler`, `MustAddEngine`, `MustAddConversions`) with generic free functions (`RegisterCodec`, `RegisterEngine`, `RegisterConversion`). - Remove unused `internal/config` package (`Config`, `GetLogger`, `ParseFromArgs`). - Remove unused `pkg/emitter` package. - Rename `Id()` to `ID()` per Go conventions. - Add documentation comments and enable `checkPublicInterface` lint rule. - Rename `reduce_one.go` to `reduce_once.go`. ### Decisions - `Engine[T]` is now a function type (`func(T) (Process[T], error)`) rather than an interface, since the only method was `Load`. - `Codec[T, U]` was split into `Codec[T]` (string marshaling) and `Conversion[T, U]` (type-to-type conversion function), which better reflects how they are actually used. - Registration uses free generic functions (`RegisterCodec`, `RegisterEngine`, `RegisterConversion`) instead of methods on `Registry`, enabling type inference at the call site. ## Benefits - Clearer separation of concerns between CLI I/O and the registry's internal type system. - Simpler abstractions: fewer interfaces, fewer wrapper types, fewer indirections. - Removing unused packages (`config`, `emitter`) reduces maintenance burden. - Naming conventions (`ID`, codecs, `reduce_once`) are more idiomatic. ## Checklist - [x] Code follows conventional commit format. - [x] Branch follows naming convention (`<type>/<description>`). - [x] Tests pass (if applicable). - [x] Documentation updated (if applicable). Reviewed-on: #43 Co-authored-by: M.V. Hutz <git@maximhutz.me> Co-committed-by: M.V. Hutz <git@maximhutz.me>
129 lines
2.5 KiB
Go
129 lines
2.5 KiB
Go
package registry
|
|
|
|
import (
|
|
"fmt"
|
|
"iter"
|
|
"maps"
|
|
)
|
|
|
|
type Registry struct {
|
|
codecs map[string]Codec
|
|
converter *Converter
|
|
engines map[string]Engine
|
|
}
|
|
|
|
func New() *Registry {
|
|
return &Registry{
|
|
codecs: map[string]Codec{},
|
|
converter: NewConverter(),
|
|
engines: map[string]Engine{},
|
|
}
|
|
}
|
|
|
|
func (r Registry) GetEngine(name string) (Engine, error) {
|
|
e, ok := r.engines[name]
|
|
if !ok {
|
|
return nil, fmt.Errorf("engine '%s' not found", name)
|
|
}
|
|
|
|
return e, nil
|
|
}
|
|
|
|
func (r Registry) ListEngines() iter.Seq[Engine] {
|
|
return maps.Values(r.engines)
|
|
}
|
|
|
|
func (r *Registry) GetDefaultEngine(id string) (Engine, error) {
|
|
for _, engine := range r.engines {
|
|
if engine.InType() == id {
|
|
return engine, nil
|
|
}
|
|
}
|
|
|
|
return nil, fmt.Errorf("no engine for '%s'", id)
|
|
}
|
|
|
|
func (r *Registry) ConvertTo(repr Repr, outType string) (Repr, error) {
|
|
path, err := r.ConversionPath(repr.ID(), outType)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
result := repr
|
|
for _, conversion := range path {
|
|
result, err = conversion.Run(result)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("converting '%s' to '%s': %w", conversion.InType(), conversion.OutType(), err)
|
|
}
|
|
}
|
|
|
|
return result, err
|
|
}
|
|
|
|
func (r *Registry) Marshal(repr Repr) (string, error) {
|
|
m, ok := r.codecs[repr.ID()]
|
|
if !ok {
|
|
return "", fmt.Errorf("no marshaler for '%s'", repr.ID())
|
|
}
|
|
|
|
return m.Encode(repr)
|
|
}
|
|
|
|
func (r *Registry) Unmarshal(s string, outType string) (Repr, error) {
|
|
m, ok := r.codecs[outType]
|
|
if !ok {
|
|
return nil, fmt.Errorf("no marshaler for '%s'", outType)
|
|
}
|
|
|
|
return m.Decode(s)
|
|
}
|
|
|
|
func reverse[T any](list []T) []T {
|
|
if list == nil {
|
|
return list
|
|
}
|
|
|
|
reversed := []T{}
|
|
|
|
for i := len(list) - 1; i >= 0; i-- {
|
|
reversed = append(reversed, list[i])
|
|
}
|
|
|
|
return reversed
|
|
}
|
|
|
|
func (r *Registry) ConversionPath(from, to string) ([]Conversion, error) {
|
|
backtrack := map[string]Conversion{}
|
|
iteration := []string{from}
|
|
for len(iteration) > 0 {
|
|
nextIteration := []string{}
|
|
|
|
for _, item := range iteration {
|
|
for _, conversion := range r.converter.ConversionsFrom(item) {
|
|
if _, ok := backtrack[conversion.OutType()]; ok {
|
|
continue
|
|
}
|
|
|
|
nextIteration = append(nextIteration, conversion.OutType())
|
|
backtrack[conversion.OutType()] = conversion
|
|
}
|
|
}
|
|
|
|
iteration = nextIteration
|
|
}
|
|
|
|
reversedPath := []Conversion{}
|
|
current := to
|
|
for current != from {
|
|
conversion, ok := backtrack[current]
|
|
if !ok {
|
|
return nil, fmt.Errorf("no valid conversion from '%s' to '%s'", from, to)
|
|
}
|
|
|
|
reversedPath = append(reversedPath, conversion)
|
|
current = conversion.InType()
|
|
}
|
|
|
|
return reverse(reversedPath), nil
|
|
}
|