refactor!: remove MinimumLoad() option (#17)
All checks were successful
CI / Check PR Title (push) Has been skipped
CI / Go Lint (push) Successful in 38s
CI / Makefile Lint (push) Successful in 36s
CI / Markdown Lint (push) Successful in 21s
CI / Unit Tests (push) Successful in 37s
CI / Fuzz Tests (push) Successful in 1m9s
CI / Mutation Tests (push) Successful in 1m18s
All checks were successful
CI / Check PR Title (push) Has been skipped
CI / Go Lint (push) Successful in 38s
CI / Makefile Lint (push) Successful in 36s
CI / Markdown Lint (push) Successful in 21s
CI / Unit Tests (push) Successful in 37s
CI / Fuzz Tests (push) Successful in 1m9s
CI / Mutation Tests (push) Successful in 1m18s
## Description The `cuckoo.MinimumLoad()` option was not a very useful option, and prone to error. By removing the ability to modify it, and setting it to something reasonable (like 5%), we can remove a whole set of errors that the user may stumble into. ## Changes - Remove `MinimumLoad()` option. - Privated `DefaultMinimumLoad`. ### Design Decisions - `DefaultMinimumLoad` should be privated because it is no longer an option. The user should not need to interact with it. ## Checklist - [x] Tests pass - [x] Docs updated Reviewed-on: #17
This commit was merged in pull request #17.
This commit is contained in:
2
table.go
2
table.go
@@ -198,7 +198,7 @@ func NewCustomTable[K, V any](hashA, hashB Hash[K], compare EqualFunc[K], option
|
||||
settings := &settings{
|
||||
growthFactor: DefaultGrowthFactor,
|
||||
bucketSize: DefaultCapacity,
|
||||
minLoadFactor: DefaultMinimumLoad,
|
||||
minLoadFactor: defaultMinimumLoad,
|
||||
}
|
||||
|
||||
for _, option := range options {
|
||||
|
||||
Reference in New Issue
Block a user