tools/go-cuckoo
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Releases 4 Wiki Activity

refactor!: remove MinimumLoad() option #17

Merged
mvhutz merged 3 commits from feat/remove-minimum-load-option into main 2026-04-03 14:51:41 +00:00
Conversation 0 Commits 3 Files Changed 3
+7 -29
mvhutz commented 2026-04-03 14:33:29 +00:00
Owner
Copy Link
Copy Source

Description

The cuckoo.MinimumLoad() option was not a very useful option, and prone to error. By removing the ability to modify it, and setting it to something reasonable (like 5%), we can remove a whole set of errors that the user may stumble into.

Changes

  • Remove MinimumLoad() option.
  • Privated DefaultMinimumLoad.

Design Decisions

  • DefaultMinimumLoad should be privated because it is no longer an option. The user should not need to interact with it.

Checklist

  • Tests pass
  • Docs updated
## Description The `cuckoo.MinimumLoad()` option was not a very useful option, and prone to error. By removing the ability to modify it, and setting it to something reasonable (like 5%), we can remove a whole set of errors that the user may stumble into. ## Changes - Remove `MinimumLoad()` option. - Privated `DefaultMinimumLoad`. ### Design Decisions - `DefaultMinimumLoad` should be privated because it is no longer an option. The user should not need to interact with it. ## Checklist - [x] Tests pass - [x] Docs updated
mvhutz added 2 commits 2026-04-03 14:33:30 +00:00
feat: remove minimum-load option, hard-coded to 5% 8b55ce7264
refactor: 'MinimumLoad' to 'defaultMinimumLoad'
CI / Check PR Title (pull_request) Failing after 18s
Details
CI / Go Lint (pull_request) Successful in 36s
Details
CI / Markdown Lint (pull_request) Successful in 22s
Details
CI / Makefile Lint (pull_request) Successful in 34s
Details
CI / Unit Tests (pull_request) Successful in 36s
Details
CI / Fuzz Tests (pull_request) Successful in 1m6s
Details
CI / Mutation Tests (pull_request) Successful in 1m1s
Details
0bdf71fd12 
- The option does not need to be exported, since it is no longer an
  option.
mvhutz added 1 commit 2026-04-03 14:48:55 +00:00
Merge branch 'main' into feat/remove-minimum-load-option
CI / Check PR Title (pull_request) Successful in 19s
Details
CI / Go Lint (pull_request) Successful in 39s
Details
CI / Makefile Lint (pull_request) Successful in 32s
Details
CI / Markdown Lint (pull_request) Successful in 22s
Details
CI / Unit Tests (pull_request) Successful in 36s
Details
CI / Fuzz Tests (pull_request) Successful in 1m8s
Details
CI / Mutation Tests (pull_request) Successful in 1m5s
Details
5c93d93f50
mvhutz merged commit 322d71f0be into main 2026-04-03 14:51:41 +00:00
mvhutz deleted branch feat/remove-minimum-load-option 2026-04-03 14:51:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
mvhutz (Maxim Hutz)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tools/go-cuckoo#17