tools/go-cuckoo
1
0
Fork 0
Code Issues 2 Pull Requests Actions Releases 4 Wiki Activity

fix!: no mixed receiver types #23

Merged
mvhutz merged 4 commits from fix/mixed-receiver-types into main 2026-04-16 03:27:49 +00:00
Conversation 0 Commits 4 Files Changed 3 +10 -7
mvhutz commented 2026-04-16 03:04:00 +00:00
Owner
Copy Link

Description

Currently, bucket and Table have mixed receiver types: some are pointer receviers, and others are value receivers.

As per the Go Wiki, you can have value and pointer receivers, just don't mix them.

Changes

  • Replace all value receivers in bucket and Table with pointer receivers.

Design Decisions

This decision was made due to the advice on the Go wiki.

Checklist

  • Tests pass
  • Docs updated
## Description Currently, `bucket` and `Table` have mixed receiver types: some are pointer receviers, and others are value receivers. As per the Go Wiki, [you can have value and pointer receivers, just don't mix them](https://go.dev/doc/faq#methods_on_values_or_pointers). ## Changes - Replace all value receivers in `bucket` and `Table` with pointer receivers. ### Design Decisions This decision was made due to the advice on the Go wiki. ## Checklist - [x] Tests pass - [x] Docs updated
mvhutz added 2 commits 2026-04-16 03:04:01 +00:00
feat: add recvcheck linter ce41d4fba2
fix!: removed all 'mixed pointer'-edness
All checks were successful
CI / Check PR Title (pull_request) Successful in 31s
Details
CI / Makefile Lint (pull_request) Successful in 45s
Details
CI / Markdown Lint (pull_request) Successful in 34s
Details
CI / Unit Tests (pull_request) Successful in 41s
Details
CI / Go Lint (pull_request) Successful in 56s
Details
CI / Fuzz Tests (pull_request) Successful in 1m39s
Details
CI / Mutation Tests (pull_request) Successful in 1m5s
Details
f35583e079
mvhutz added 1 commit 2026-04-16 03:17:58 +00:00
Merge remote-tracking branch 'origin' into fix/mixed-receiver-types f0c9fb9acf
mvhutz changed title from fix!: no mixed receiver types to fix!: no mixed receiver type 2026-04-16 03:22:49 +00:00
mvhutz changed title from fix!: no mixed receiver type to fix!: no mixed receiver types 2026-04-16 03:23:01 +00:00
mvhutz added 1 commit 2026-04-16 03:23:44 +00:00
test: bump cicd pipeline
All checks were successful
CI / Check PR Title (pull_request) Successful in 30s
Details
CI / Go Lint (pull_request) Successful in 53s
Details
CI / Makefile Lint (pull_request) Successful in 50s
Details
CI / Markdown Lint (pull_request) Successful in 34s
Details
CI / Unit Tests (pull_request) Successful in 50s
Details
CI / Fuzz Tests (pull_request) Successful in 1m20s
Details
CI / Mutation Tests (pull_request) Successful in 2m50s
Details
99f5548237
mvhutz merged commit 29ba6bfd4d into main 2026-04-16 03:27:49 +00:00
mvhutz deleted branch fix/mixed-receiver-types 2026-04-16 03:27:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
mvhutz
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tools/go-cuckoo#23
Delete Branch "fix/mixed-receiver-types"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?